Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade scala-parser-combinators and scala-xml #439

Merged
merged 2 commits into from
Sep 1, 2021

Conversation

mkurz
Copy link
Member

@mkurz mkurz commented Aug 31, 2021

twirl is a sbt-plugin. sbt-plugins get published for Scala 2.12.
The 2.12.x scala compiler depends on 1.x versions for both scala-parser-combinators and scala-xml, see https://github.com/scala/scala/blob/2.12.x/versions.properties#L21-L22
If we would use 2.x versions, we would run into annoying dependency conflicts in sbt 1.5+
There is no need to upgrade these versions to 2.x, the only reason would be if we would cross build for Scala 3, but sbt-plugins do not need to be cross build for Scala 3.

See discussion in scala/scala#9743

@SethTisue
Copy link
Member

add a .scala-steward.conf file to prevent the steward from attempting the upgrades?

@mkurz
Copy link
Member Author

mkurz commented Aug 31, 2021

add a .scala-steward.conf file to prevent the steward from attempting the upgrades?

Fantastic idea!

@mkurz
Copy link
Member Author

mkurz commented Aug 31, 2021

@SethTisue Done!

@mkurz mkurz merged commit 1622c35 into playframework:main Sep 1, 2021
@mkurz mkurz deleted the downgrade_modules branch September 1, 2021 13:45
takezoe added a commit to scalatra/scalatra that referenced this pull request Sep 25, 2021
takezoe added a commit to scalatra/scalatra that referenced this pull request Sep 25, 2021
takezoe added a commit to scalatra/scalatra that referenced this pull request Sep 25, 2021
takezoe added a commit to scalatra/scalatra that referenced this pull request Sep 25, 2021
takezoe added a commit to scalatra/scalatra that referenced this pull request Sep 25, 2021
takezoe added a commit to scalatra/scalatra that referenced this pull request Sep 25, 2021
magnolia-k added a commit to scalatra/scalatra that referenced this pull request Oct 3, 2021
* Fix CI trigger (#1245)

* Downgrade scala-xml in Scala2 following twirl (#1286)

playframework/twirl#439

* Release Scalatra 2.8.1

* Exclude scala-xml from json4s-xml (#1288)

* Release Scalatra 2.8.2

* Updated README

update version 2.7.x -> 2.8.x

* Update version file

Co-authored-by: Naoki Takezoe <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants